Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maven-failsafe-plugin version definition #209 #211

Merged
merged 4 commits into from
Jan 8, 2016

Conversation

btokadanob
Copy link
Contributor

  • add vesrion 2.19 maven-failsafe-plugin

#209

please review
by btokadanob


@@ -16,6 +16,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>${maven.failsafe.plugin.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add <pluginManagement> for maven-failsafe-plugin at parent pom and define version there.

@btokadanob
Copy link
Contributor Author

  • fix definition position

f2a618c
629a5e7


<maven.failsafe.plugin.version>2.19</maven.failsafe.plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change to <maven-failsafe-plugin.version> (. -> -)
  • move down of <org.codehaus.mojo.build-helper-maven-plugi.version>

@btokadanob
Copy link
Contributor Author

  • fix version properties

5094ffc


btshimizukza added a commit that referenced this pull request Jan 8, 2016
…fe-pluginVersion

add maven-failsafe-plugin version definition #209
@btshimizukza btshimizukza merged commit 19b9db3 into master Jan 8, 2016
@btshimizukza btshimizukza deleted the issues/209_addMaven-failsafe-pluginVersion branch January 8, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants